dengzhhu653 commented on code in PR #6785:
URL: https://github.com/apache/hive/pull/6785#discussion_r4043876724
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java:
##########
@@ -513,127 +519,262 @@ static void prewarm(RawStore rawStore) {
}
sharedCache.populateDatabasesInCache(databases);
LOG.info("Databases cache is now prewarmed. Now adding tables,
partitions and statistics to the cache");
- int numberOfDatabasesCachedSoFar = 0;
Review Comment:
Can you separate the prewarm from this class please, and create an interface
to warm up the cache?
An interface for example:
```
interface MetaCachePreWarm extends AutoClosable, Configurable {
void initialize() throws MetaException;
void preWarm() throws MetaException;
....
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
