sankalpsthakur opened a new pull request, #6799:
URL: https://github.com/apache/hive/pull/6799

   ### What changes were proposed in this pull request?
   
   Add class-level Javadoc on the window-function UDAFs that Checkstyle 
`JavadocType` reported as missing a comment:
   
   - `GenericUDAFRank` (`rank`)
   - `GenericUDAFDenseRank` (`dense_rank`)
   - `GenericUDAFCumeDist` (`cume_dist`)
   - `GenericUDAFPercentRank` (`percent_rank`)
   - `GenericUDAFRowNumber` (`row_number`)
   - `GenericUDAFNTile` (`ntile`)
   - `GenericUDAFLead` (`lead`)
   - `GenericUDAFLag` (`lag`)
   - `GenericUDAFFirstValue` (`first_value`)
   - `GenericUDAFLastValue` (`last_value`)
   
   No behavior change.
   
   JIRA: https://issues.apache.org/jira/browse/HIVE-22295
   
   ### Why are the changes needed?
   
   Public UDAF classes need a Javadoc comment so `JavadocType` is satisfied and 
the generated API docs describe each window function.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Javadoc only. No runtime or SQL behavior change.
   
   ### How was this patch tested?
   
   Docs-only. Existing UDAF/window-function tests are unchanged. Precommit CI 
on this PR should cover compilation and Checkstyle.
   
   ### ICLA
   
   An Apache ICLA is required for Hive contributions. This PR does not claim 
that an ICLA has been signed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to