zabetak commented on code in PR #6781:
URL: https://github.com/apache/hive/pull/6781#discussion_r4047039014
##########
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java:
##########
@@ -343,6 +344,33 @@ public TPCDSFormattedCBOConfig() {
}
}
+ public static class TPCDSIcebergS3CliConfig extends AbstractCliConfig {
+ public TPCDSIcebergS3CliConfig() {
+ super(CorePerfCliDriver.class);
+ setQueryDir("ql/src/test/queries/clientpositive/perf");
+
setLogDir("itests/qtest/target/qfile-results/clientpositive/perf/tpcds1tb/iceberg");
+
setResultsDir("ql/src/test/results/clientpositive/perf/tpcds1tb/iceberg");
+
+ setInitScript("q_init_tpcds_iceberg.sql");
+ setCleanupScript("q_test_cleanup_tez.sql");
Review Comment:
Fixed
https://github.com/apache/hive/pull/6781/commits/e35b69d3601760747f97935995f1a1cb10405f0b
I have the impression that all cleanup scripts are redundant because every
test runs in its own JVM so the whole process comes down after the execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
