abstractdog commented on PR #6578: URL: https://github.com/apache/hive/pull/6578#issuecomment-5793960797
> don't TypesFromStringToDatePageReader & TypesFromStringToTimestampPageReader duplicate existing code used in Hive ORC ? not necessarily: these converters seem to depend on format-specific domain classes like `org.apache.parquet.column.Dictionary`, so adding new inner classes to `ParquetDataColumnReaderFactory.java` seems to be just following a pattern -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
