tanishq-chugh commented on code in PR #6820:
URL: https://github.com/apache/hive/pull/6820#discussion_r4113479223
##########
packaging/src/kubernetes/src/java/org/apache/hive/kubernetes/operator/dependent/HiveDependentResource.java:
##########
@@ -976,4 +978,27 @@ private static String buildJmxExporterConfig(String
component) {
return sb.toString();
}
+ protected static DeploymentStrategy buildDeploymentUpdateStrategy(String
updateStrategy) {
+ String strategy = updateStrategy != null ? updateStrategy :
"RollingUpdate";
+ if ("Recreate".equalsIgnoreCase(strategy)) {
+ return new DeploymentStrategyBuilder().withType("Recreate").build();
+ }
+ return new DeploymentStrategyBuilder()
+ .withType("RollingUpdate")
Review Comment:
Addressed in commit -
[c60dcd0](https://github.com/apache/hive/pull/6820/commits/c60dcd0646e315f2df887982b3b3874398f756d7)
##########
packaging/src/kubernetes/src/java/org/apache/hive/kubernetes/operator/model/spec/LlapSpec.java:
##########
@@ -129,7 +137,8 @@ public record LlapTezAmSpec(
envVars = envVars != null ? envVars : List.of();
autoscaling = autoscaling != null ? autoscaling : new AutoscalingSpec(
false, 0, 1, 20, 60, 900, 600, 10, 0, 0, null);
- tezAm = tezAm != null ? tezAm : new LlapTezAmSpec(null, null, null, null);
+ tezAm = tezAm != null ? tezAm : new LlapTezAmSpec(null, null, null, null,
null);
+ updateStrategy = updateStrategy != null ? updateStrategy : "RollingUpdate";
Review Comment:
Addressed in commit -
[cf222b6](https://github.com/apache/hive/pull/6820/commits/cf222b6e14a54459b5bcf56c075a404bf270655a)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
