deniskuzZ commented on code in PR #6824: URL: https://github.com/apache/hive/pull/6824#discussion_r4123397197
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPruningEventDesc.java:
##########
@@ -127,8 +123,7 @@ public boolean isSame(OperatorDesc other) {
DynamicPruningEventDesc otherDesc = (DynamicPruningEventDesc) other;
return Objects.equals(getTargetColumnName(),
otherDesc.getTargetColumnName()) &&
Objects.equals(getTargetColumnType(),
otherDesc.getTargetColumnType()) &&
- Objects.equals(getPartKeyString(), otherDesc.getPartKeyString()) &&
- Objects.equals(getPartPredicateString(),
otherDesc.getPartPredicateString());
+ Objects.equals(getPartKeyString(), otherDesc.getPartKeyString());
Review Comment:
With different DPP sources, nothing merges wrongly, with or without the fix,
on Iceberg or native:
````
┌─────────────┬─────────┬────────────┬─────────┬──────────────┬────────┐
│ Build │ Table │ DPP events │ Targets │ Scans │ Result │
├─────────────┼─────────┼────────────┼─────────┼──────────────┼────────┤
│ with fix │ Iceberg │ 2 │ a, b │ Map 1, Map 4 │ 2000 │
├─────────────┼─────────┼────────────┼─────────┼──────────────┼────────┤
│ with fix │ native │ 2 │ a, b │ Map 1, Map 4 │ 2000 │
├─────────────┼─────────┼────────────┼─────────┼──────────────┼────────┤
│ without fix │ Iceberg │ 2 │ a, b │ Map 1, Map 4 │ 2000 │
├─────────────┼─────────┼────────────┼─────────┼──────────────┼────────┤
│ without fix │ native │ 2 │ a, b │ Map 1, Map 4 │ 2000 │
└─────────────┴─────────┴────────────┴─────────┴──────────────┴────────┘
````
The plan is identical in all four runs:
- SWO merges the two date_dim reads into Map 5.
- The two differently filtered branches stay separate, each with its own
DPP event and target.
- The count is correct (1000 + 1000).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
