Aggarwal-Raghav commented on code in PR #6832:
URL: https://github.com/apache/hive/pull/6832#discussion_r4144873087
##########
.github/workflows/build.yml:
##########
@@ -45,8 +45,51 @@ jobs:
java-version: '21'
distribution: 'temurin'
cache: maven
+ - name: Cache Thrift 0.16.0
+ if: runner.os == 'Linux'
+ id: cache-thrift
+ uses: actions/cache@v4
+ with:
+ path: ${{ github.workspace }}/thrift-0.16.0-install
+ key: thrift-0.16.0-${{ runner.os }}-${{ runner.arch }}
+ - name: Install Thrift 0.16.0
+ if: runner.os == 'Linux' && steps.cache-thrift.outputs.cache-hit !=
'true'
+ run: |
+ sudo apt-get update && sudo apt-get install -y automake bison flex
g++ libboost-all-dev libevent-dev libssl-dev libtool make pkg-config
+ wget -q
https://archive.apache.org/dist/thrift/0.16.0/thrift-0.16.0.tar.gz
+ tar xzf thrift-0.16.0.tar.gz
+ cd thrift-0.16.0
+ ./bootstrap.sh
Review Comment:
i think `./bootstrap.sh` can be skipped as per:
https://thrift.apache.org/docs/BuildingFromSource
> If you are building from the first time out of the source repository, you
will need to generate the configure scripts. (This is not necessary if you
downloaded a released tarball.) From the top directory, do:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
