deniskuzZ commented on code in PR #6793:
URL: https://github.com/apache/hive/pull/6793#discussion_r4155079140
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java:
##########
@@ -171,7 +178,8 @@ private LlapIoImpl(Configuration conf) throws IOException {
MetadataCache metadataCache = null;
SerDeLowLevelCacheImpl serdeCache = null; // TODO: extract interface when
needed
- BufferUsageManager bufferManagerOrc = null, bufferManagerGeneric = null;
+ BufferUsageManager bufferManagerData = null;
Review Comment:
I think `bufferManagerData` is pure redundancy with the `bufferManager`
field and should be removed in favor of passing bufferManager directly, while
bufferManagerGeneric is legitimately distinct and should stay
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java:
##########
@@ -219,7 +227,9 @@ private LlapIoImpl(Configuration conf) throws IOException {
cachePolicyWrapper.setEvictionListener(e);
cacheImpl.startThreads(); // Start the cache threads.
- bufferManager = bufferManagerOrc = cacheImpl; // Cache also serves as
buffer manager.
+ // Cache also serves as buffer manager for both data and generic
(encoded/serde) paths.
+ bufferManagerData = cacheImpl;
Review Comment:
I think bufferManagerData is pure redundancy with the bufferManager field
and should be removed in favor of passing bufferManager directly, while
bufferManagerGeneric is legitimately distinct and should stay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
