deniskuzZ commented on code in PR #6789:
URL: https://github.com/apache/hive/pull/6789#discussion_r4164768940


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2154,6 +2154,13 @@ public static enum ConfVars {
         "If this is set to true the URI for auth will have the default 
location masked with DEFAULT_TABLE_LOCATION"),
     
HIVE_ICEBERG_ALLOW_DATAFILES_IN_TABLE_LOCATION_ONLY("hive.iceberg.allow.datafiles.in.table.location.only",
 false,
         "If this is set to true, then all the data files being read should be 
withing the table location"),
+    HIVE_ICEBERG_REST_SCAN_PLANNING_MODE(
+        "hive.iceberg.rest.scan-planning-mode", "client",
+        new StringSet("client", "server"),
+        "Hive-wide default for Iceberg REST catalog scan planning in Tez/MR 
split generation, aligned with\n" +
+        "catalog property scan-planning-mode. In server mode, catalog settings 
are propagated to jobs and\n" +

Review Comment:
   why do we need these details here? this is user facing config
   
   ````
   In server mode, catalog settings are propagated to jobs and\n" +
           "executors reload a REST table so planning can use POST /plan. In 
client mode (default), split\n" +
           "generation uses the serialized table snapshot even if a catalog 
requests server-side scan planning.
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to