deniskuzZ commented on code in PR #6846:
URL: https://github.com/apache/hive/pull/6846#discussion_r4218816886
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java:
##########
@@ -228,6 +227,8 @@ private LlapRecordReader(MapWork mapWork, JobConf job,
FileSplit split,
// Create the consumer of encoded data; it will coordinate decoding to
CVBs.
feedback = rp = cvp.createReadPipeline(this, split, includes, sarg,
counters, includes,
sourceInputFormat, sourceSerDe, reporter, job,
mapWork.getPathToPartitionInfo());
+ missingColIndices = includes.getReaderLogicalColumnIds().stream()
+ .filter(idx ->
!includes.getLogicalOrderedColumnIds().contains(idx)).toList();
Review Comment:
This now runs once per split in the constructor, over projected columns only
(tens, at most a few hundred)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
