deniskuzZ commented on code in PR #6856:
URL: https://github.com/apache/hive/pull/6856#discussion_r4222762527
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##########
@@ -335,8 +335,8 @@ static void verifyMetadataHash(TableMetadata metadata,
String metadataHashFromHM
}
private static byte[] hashOf(TableMetadata tableMetadata) {
- try (HashWriter hashWriter = new HashWriter("SHA-256",
StandardCharsets.UTF_8)) {
- JsonGenerator generator = JsonUtil.factory().createGenerator(hashWriter);
+ try (HashWriter hashWriter = new HashWriter("SHA-256",
StandardCharsets.UTF_8);
Review Comment:
is there a constant for "SHA-256" we can use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
