Aggarwal-Raghav commented on code in PR #6856:
URL: https://github.com/apache/hive/pull/6856#discussion_r4222751927
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveFileWriterFactory.java:
##########
@@ -47,80 +57,66 @@ class HiveFileWriterFactory extends
BaseFileWriterFactory<Record> {
FileFormat deleteFileFormat,
int[] equalityFieldIds,
Schema equalityDeleteRowSchema,
- SortOrder equalityDeleteSortOrder,
- Schema positionDeleteRowSchema) {
- super(
- table,
- dataFileFormat,
- dataSchema,
- dataSortOrder,
- deleteFileFormat,
- equalityFieldIds,
- equalityDeleteRowSchema,
- equalityDeleteSortOrder,
- positionDeleteRowSchema);
- properties = table.properties();
+ SortOrder equalityDeleteSortOrder) {
+ this.table = table;
+ this.dataFileFormat = dataFileFormat;
+ this.dataSchema = dataSchema;
+ this.properties = table.properties();
+
+ GenericFileWriterFactory.Builder builder = new
GenericFileWriterFactory.Builder(table)
+ .dataFileFormat(dataFileFormat)
+ .dataSchema(dataSchema)
+ .dataSortOrder(dataSortOrder)
+ .deleteFileFormat(deleteFileFormat)
+ .equalityFieldIds(equalityFieldIds)
+ .equalityDeleteRowSchema(equalityDeleteRowSchema)
+ .equalityDeleteSortOrder(equalityDeleteSortOrder);
+
+ this.delegate = builder.build();
}
static Builder builderFor(Table table) {
return new Builder(table);
}
@Override
- protected void configureDataWrite(Avro.DataWriteBuilder builder) {
- builder.createWriterFunc(DataWriter::create);
- }
-
- @Override
- protected void configureEqualityDelete(Avro.DeleteWriteBuilder builder) {
-
- }
-
- @Override
- protected void configurePositionDelete(Avro.DeleteWriteBuilder builder) {
- builder.createWriterFunc(DataWriter::create);
- }
-
- @Override
- protected void configureDataWrite(Parquet.DataWriteBuilder builder) {
- builder.createWriterFunc(GenericParquetWriter::create);
- // Configure variant shredding if enabled and a sample record is available
- if (VariantUtil.shouldUseVariantShredding(properties, dataSchema())) {
-
builder.variantShreddingFunc(VariantUtil.variantShreddingFunc(sampleRecord,
dataSchema()));
+ public DataWriter<Record> newDataWriter(EncryptedOutputFile file,
PartitionSpec spec, StructLike partition) {
+ if (dataFileFormat == FileFormat.PARQUET &&
VariantUtil.shouldUseVariantShredding(properties, dataSchema)) {
Review Comment:
Yes. Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
