ramitg254 commented on code in PR #6861: URL: https://github.com/apache/hive/pull/6861#discussion_r4247597434
########## ql/src/test/org/apache/hadoop/hive/ql/exec/vector/ptf/TestVectorPTFEvaluatorNTile.java: ########## @@ -0,0 +1,385 @@ +/* Review Comment: generally qtest covers all the function related cases in execution and we don't follow convention of using junit test case for each ptf function so I think we should stick to qtest only. do we have any explicitly behaviour which is crucial to be tested via junit test and can't be tested via q test ? if not then we should drop this entirely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
