Aggarwal-Raghav commented on code in PR #6862:
URL: https://github.com/apache/hive/pull/6862#discussion_r4273177635
##########
iceberg/iceberg-handler/src/test/queries/positive/iceberg_v2_deletes.q:
##########
@@ -1,93 +0,0 @@
--- Mask random uuid
---! qt:replace:/(\s+'uuid'=')\S+('\s*)/$1#Masked#$2/
--- Mask a random snapshot id
---! qt:replace:/(\s\'current-snapshot-id\'=\')(\d+)(\')/$1#Masked#$3/
--- Mask added file size
---! qt:replace:/(\S+\"added-files-size\":\")(\d+)(\")/$1#Masked#$3/
--- Mask total file size
---! qt:replace:/(\S+\"total-files-size\":\")(\d+)(\")/$1#Masked#$3/
--- Mask current-snapshot-timestamp-ms
---! qt:replace:/(\s\'current-snapshot-timestamp-ms\'=\')(\d+)(\')/$1#Masked#$3/
--- Mask iceberg version
---!
qt:replace:/("iceberg-version":")(\w+\s\w+\s\d+\.\d+\.\d+\s\(\w+\s\w+\))/$1#Masked#/
-
--- create an unpartitioned table with skip delete data set to false
- create table ice01 (id int) Stored by Iceberg stored as ORC
Review Comment:
iceberg_v2_deletes.q was added as part of
[HIVE-26734](https://issues.apache.org/jira/browse/HIVE-26734),
It was doing
1. Writes delete with row data (skiprowdata=false).
2. Runs ALTER TABLE ... SET ('iceberg.delete.skiprowdata'='true').
3. Writes delete without row data.
4. Runs SELECT * to verify Hive's reader can scan both delete formats
side-by-side.
Without skiprowdata, I don't see much value plus similar testing if we just
remove the config and let the q file exist is happeing in delete_all_iceberg.q,
delete_iceberg_partitioned_orc.q and delete_iceberg_mixed.q
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
