saihemanth-cloudera commented on code in PR #6868:
URL: https://github.com/apache/hive/pull/6868#discussion_r4289569604
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/CompactorTasks.java:
##########
@@ -110,6 +126,7 @@ public void takeLeadership(LeaderElection election) throws
Exception {
throw new IllegalStateException("There should be no running tasks before
taking the leadership!");
}
+ isDynamic = election.isDynamic();
Review Comment:
Same ask here: a dynamic-election test with initiator/cleaner disabled would
make this much safer.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/HouseKeepingTasks.java:
##########
@@ -102,6 +109,7 @@ public void takeLeadership(LeaderElection election) throws
Exception {
ThreadFactory threadFactory = new ThreadFactoryBuilder().setDaemon(true)
.setNameFormat("Metastore Scheduled Worker(" + election.getName() + ")
%d").build();
final List<MetastoreTaskThread> tasks;
+ isDynamic = election.isDynamic();
Review Comment:
This is the core behavior change. Can we add a lock-election test with
housekeeping disabled so this doesn’t regress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
