difin commented on code in PR #6789:
URL: https://github.com/apache/hive/pull/6789#discussion_r4289579218
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveTableUtil.java:
##########
@@ -259,6 +262,57 @@ public static Table deserializeTable(Configuration config,
String name) {
return table;
}
+ /**
+ * Resolves the Iceberg {@link Table} for split generation ({@code
IcebergInputFormat#getSplits}).
+ *
+ * <p>Serialized tables ({@link SerializableTable}) only carry a metadata
snapshot and produce
+ * {@link org.apache.iceberg.DataTableScan} (client-side manifest planning).
When REST catalog
+ * server-side scan planning is enabled, reload the live table from the
catalog so
+ * {@code table.newScan()} returns {@link
org.apache.iceberg.rest.RESTTableScan} and issues
+ * {@code POST /plan} on the REST server.
+ *
+ * <p>Intra-transaction read-after-write ({@link
InputFormatConfig#TABLE_METADATA_LOCATION}) still
+ * uses the deserialized snapshot so uncommitted metadata is visible.
+ */
+ public static Table resolveTableForScanPlanning(Configuration conf, String
tableIdentifier) {
+ if (shouldReloadForServerSideScanPlanning(conf)) {
Review Comment:
Thanks — all three blockers are addressed:
- Snapshot drift — In getSplits, when server mode applies and there’s no
explicit snapshot/ref/as-of, we pin the REST scan to the serialized
compile-time table (pinServerSideScanToSerializedTable). Tests:
`TestServerSideScanSnapshotPinning`,
`TestHiveIcebergServerSideScanPlanningServerIT#serverSidePlanningPinsSerializedSnapshotAfterCatalogAdvances`.
- Secrets — Non-secret catalog props → job properties;
credential/token/oauth (and hidden keys) → `configureInputJobCredentials`.
Test: `propagateInputJobCredentialsRoutesCredentialAndOAuthToJobSecrets`.
- Catalog leak — using `try (CloseableRestCatalog …)` in `getSplits`.
catalog is closed after `planTasks()` materializes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
