ryukobayashi commented on code in PR #6885: URL: https://github.com/apache/hive/pull/6885#discussion_r4321954665
########## ql/src/test/queries/clientpositive/hive_30146_left_join.q: ########## @@ -0,0 +1,20 @@ +set hive.cbo.enable=true; +set hive.stats.fetch.column.stats=true; +set hive.auto.convert.join=false; +-- SORT_QUERY_RESULTS + +with t1 as + (select stack(3, 1, 1, 2) as (k)), + t2 as + (select stack(4, 1, 1, 3, 4) as (k)) +select count(*) +from (select distinct k from t1) a Review Comment: The new `testAggregateLeftJoinWithAggregateOnLeftIsNotRewritten` covers the Aggregate form: the left input is grouped on the join key, and an Aggregate is placed above the join. `UNION` is not directly matched by `HiveSemiJoinRule`, whose operands require a Project or Aggregate directly above the Join. Therefore, I kept this regression test focused on the affected rule shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
