okumin commented on code in PR #6458: URL: https://github.com/apache/hive/pull/6458#discussion_r4335780647
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/credential/VendedCredentialProvider.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hadoop.hive.metastore.credential; + +import org.apache.hadoop.classification.InterfaceStability; + +import java.util.List; + +/** + * A credential-vending service. + */ [email protected] +public interface VendedCredentialProvider { + /** + * Checks whether this provider supports the given access request. + * + * @param request the access request + * @return true if this provider supports the given access request + */ + boolean supports(StorageAccessRequest request); + + /** + * Vends credentials for the given access. + * + * @param username the authenticated username + * @param accessRequests the vending requests + * @return a list of vended credentials + */ + List<VendedStorageCredential> vend(String username, List<StorageAccessRequest> accessRequests); Review Comment: The change is acceptable. What do we use `catalog` and `ident` for there? As this SPI belongs to metastore-server (because I guess the Thrift API could also support Credential Vending), TableIdentifier may become the database name and table name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
