saihemanth-cloudera commented on code in PR #6899:
URL: https://github.com/apache/hive/pull/6899#discussion_r4340873570


##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java:
##########
@@ -165,6 +175,10 @@ public List<HivePrivilegeObject> 
filterListCmdObjects(List<HivePrivilegeObject>
     return listObjs;
   }
 
+  private static boolean isMetastoreJdbcStorageUri(String uri) {
+    return uri != null && uri.startsWith("jdbc:metastore://");
+  }

Review Comment:
   Optional hardening (trim + case-insensitive prefix) is fine but not required 
for security. The real control is DDL + JdbcStorageConfigManager.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to