abstractdog commented on code in PR #6902:
URL: https://github.com/apache/hive/pull/6902#discussion_r4345690952
##########
packaging/src/main/assembly/bin.xml:
##########
@@ -41,6 +41,8 @@
<excludes>
<exclude>org.apache.calcite:*</exclude>
<exclude>org.apache.hadoop:*</exclude>
+ <!-- TEZ_HOME provides Tez, as HADOOP_HOME provides Hadoop -->
+ <exclude>org.apache.tez:*</exclude>
Review Comment:
first I thought this change might break things, but actually it could make
sense
I can see that without this patch, the dist package contains tez-api jar
only, which I believe was expected
however, looking at the contents further, the dist package doesn't contain
Hadoop JARs at all either, so yeah, the same could apply to tez as well
hive-exec jar has both tez and hadoop jars shaded, so any runtime problems
later can be solved by:
1. shading further packages to hive-exec jar
2. prepare the actual platform to have tez-api jar on e.g. HS2 classpath
I think, in case of any complaint about the tez-api jar removed from dist
package, we can claim that hadoop jars are not present either; however, we
should define this as a user-facing change: cluster installs that depended on
the tez-api jar unpacked from hive dist package now should take care of that
jar in other ways
I'm adding separate comments about particular issues that might handled here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
