ggangadharan commented on code in PR #6898:
URL: https://github.com/apache/hive/pull/6898#discussion_r4347651054
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPTFDesc.java:
##########
@@ -108,21 +111,40 @@ public enum SupportedFunctionType {
LAST_VALUE,
COUNT(true),
LEAD,
- LAG;
+ LAG,
+ VARIANCE(VarianceKind.VARIANCE),
+ VAR_POP(VarianceKind.VARIANCE),
+ VAR_SAMP(VarianceKind.VARIANCE_SAMPLE),
+ STD(VarianceKind.STANDARD_DEVIATION),
+ STDDEV(VarianceKind.STANDARD_DEVIATION),
+ STDDEV_POP(VarianceKind.STANDARD_DEVIATION),
+ STDDEV_SAMP(VarianceKind.STANDARD_DEVIATION_SAMPLE);
private final boolean supportDistinct;
+ private final VarianceKind varianceKind;
SupportedFunctionType() {
- supportDistinct = false;
+ this(false);
Review Comment:
Same as above: with final fields an empty body doesn't compile, so it now
delegates with this(false, null).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
