okumin commented on code in PR #6724:
URL: https://github.com/apache/hive/pull/6724#discussion_r4397792348
##########
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemon.java:
##########
@@ -106,7 +106,7 @@ public void testEnforceProperNumberOfIOThreads() throws
IOException {
HiveConf.setIntVar(hiveConf, HiveConf.ConfVars.LLAP_IO_THREADPOOL_SIZE, 3);
daemon = new LlapDaemon(hiveConf, 4, LlapDaemon.getTotalHeapSize(), true,
false,
- -1, new String[1], 0, false, 0,0, 0, defaultWebPort,
"TestLlapDaemon");
+ -1, new String[1], 0,0, 0, defaultWebPort, "TestLlapDaemon");
Review Comment:
Thank you. This patch is handmade, and my IDE hid the issue 🫣
<img width="621" height="66" alt="image"
src="https://github.com/user-attachments/assets/eee72d7b-573e-4b00-94e7-327a58364b8d";
/>
https://github.com/apache/hive/pull/6724/changes/0034e1643ba3ad3589dde8ab67208ecfe74f9538
##########
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemon.java:
##########
@@ -155,7 +155,7 @@ public void testUpdateRegistration() throws IOException {
int enabledQueue = 2;
daemon = new LlapDaemon(hiveConf, 1, LlapDaemon.getTotalHeapSize(), false,
false,
- -1, new String[1], 0, false, 0,0, 0, defaultWebPort, "TestLlapDaemon");
+ -1, new String[1], 0,0, 0, defaultWebPort, "TestLlapDaemon");
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
