thomasrebele commented on code in PR #6825:
URL: https://github.com/apache/hive/pull/6825#discussion_r4422499381
##########
standalone-metastore/metastore-server/src/test/resources/sql/postgres/migrate-metastore-dump-to-4.3.0.postgres.sql:
##########
@@ -0,0 +1,56 @@
+-- The file has some overlapping with
upgrade-3.2.0-to-4.0.0-alpha-1.postgres.sql
+SELECT 'Upgrading MetaStore schema from 3.1.3000 to 4.3.0';
+
+-- The dump was created from a metastore where some columns had the wrong
types.
+-- Fix those column types that some tests verify.
+UPDATE "COLUMNS_V2" c
+SET "TYPE_NAME" = 'char(16)'
+WHERE "COLUMN_NAME" in ('c_customer_id', 'ca_address_id')
+AND EXISTS (SELECT * FROM "SDS" s WHERE s."CD_ID" = c."CD_ID");
+
+-- HIVE-20793
+ALTER TABLE "WM_RESOURCEPLAN" ADD "NS" character varying(128);
+UPDATE "WM_RESOURCEPLAN" SET "NS" = 'default' WHERE "NS" IS NULL;
+ALTER TABLE "WM_RESOURCEPLAN" DROP CONSTRAINT "UNIQUE_WM_RESOURCEPLAN";
+ALTER TABLE ONLY "WM_RESOURCEPLAN" ADD CONSTRAINT "UNIQUE_WM_RESOURCEPLAN"
UNIQUE ("NS", "NAME");
+
+-- HIVE-22046 (DEFAULT HIVE)
+UPDATE "TAB_COL_STATS" SET "ENGINE" = 'hive' WHERE "ENGINE" IS NULL;
+UPDATE "PART_COL_STATS" SET "ENGINE" = 'hive' WHERE "ENGINE" IS NULL;
+
+-- HIVE-22728
+ALTER TABLE "KEY_CONSTRAINTS" DROP CONSTRAINT "KEY_CONSTRAINTS_pkey";
+ALTER TABLE "KEY_CONSTRAINTS" ADD CONSTRAINT "CONSTRAINTS_PK" PRIMARY KEY
("PARENT_TBL_ID", "CONSTRAINT_NAME", "POSITION");
+
+-- HIVE-23048
+INSERT INTO "TXNS" ("TXN_ID", "TXN_STATE", "TXN_STARTED",
"TXN_LAST_HEARTBEAT", "TXN_USER", "TXN_HOST")
+SELECT COALESCE(MAX("CTC_TXNID"),0), 'c', 0, 0, '', '' FROM
"COMPLETED_TXN_COMPONENTS";
+CREATE SEQUENCE "TXNS_TXN_ID_SEQ" MINVALUE 0 OWNED BY "TXNS"."TXN_ID";
+select setval('"TXNS_TXN_ID_SEQ"', (SELECT MAX("TXN_ID") FROM "TXNS"));
+ALTER TABLE "TXNS" ALTER "TXN_ID" SET DEFAULT nextval('"TXNS_TXN_ID_SEQ"');
+
+ALTER TABLE "NEXT_TXN_ID" RENAME TO "TXN_LOCK_TBL";
+ALTER TABLE "TXN_LOCK_TBL" RENAME COLUMN "NTXN_NEXT" TO "TXN_LOCK";
+
+--Increase the size of RM_PROGRESS to accomodate the replication statistics
+ALTER TABLE "REPLICATION_METRICS" ALTER "RM_PROGRESS" TYPE varchar(24000);
+
+ALTER TABLE "REPLICATION_METRICS" ALTER "RM_PROGRESS" TYPE varchar(10000);
+
+-- HIVE-24770
+UPDATE "SERDES" SET "SLIB"='org.apache.hadoop.hive.serde2.MultiDelimitSerDe'
where "SLIB"='org.apache.hadoop.hive.contrib.serde2.MultiDelimitSerDe';
+UPDATE "DBS" SET "TYPE"= 'NATIVE' WHERE "TYPE" IS NULL;
+
+-- HIVE-29178
+-- Table structure for CATALOG_PARAMS
+CREATE TABLE "CATALOG_PARAMS" (
+ "CTLG_ID" BIGINT NOT NULL,
+ "PARAM_KEY" VARCHAR(180) NOT NULL,
+ "PARAM_VALUE" VARCHAR(4000) DEFAULT NULL,
+ PRIMARY KEY ("CTLG_ID", "PARAM_KEY"),
+ CONSTRAINT "CATALOG_PARAMS_FK1" FOREIGN KEY ("CTLG_ID") REFERENCES "CTLGS"
("CTLG_ID") ON DELETE CASCADE
+);
+
Review Comment:
Thanks, fixed.
##########
standalone-metastore/metastore-server/src/test/resources/sql/postgres/migrate-metastore-dump-to-4.3.0.postgres.sql:
##########
@@ -0,0 +1,56 @@
+-- The file has some overlapping with
upgrade-3.2.0-to-4.0.0-alpha-1.postgres.sql
+SELECT 'Upgrading MetaStore schema from 3.1.3000 to 4.3.0';
+
+-- The dump was created from a metastore where some columns had the wrong
types.
+-- Fix those column types that some tests verify.
+UPDATE "COLUMNS_V2" c
+SET "TYPE_NAME" = 'char(16)'
+WHERE "COLUMN_NAME" in ('c_customer_id', 'ca_address_id')
+AND EXISTS (SELECT * FROM "SDS" s WHERE s."CD_ID" = c."CD_ID");
Review Comment:
Seems that the wrong column type also needs to be fixed in TAB_COL_STATS.
Afterwards, the stats show up again. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
