InvisibleProgrammer commented on PR #6893: URL: https://github.com/apache/hive/pull/6893#issuecomment-6580334033
> > > I don't have a good understanding of the retry in HiveConnection, but the rest(thrift changes) sounds good. > > > > > > @dengzhhu653 : Thrift upgraded httpclient from 4 to 5. It is a breaking change. Some parts of the original retry logic completely have been completely removed from httpclient so it was necessary to rewrite that to keep the original behavior. > > Sounds like HiveConnection(SAML) is the only place where has the incompatible issue, other old clients can still speak with HS2/HMS, right? Yes. We are testing it actively on downstream. Didn't have a failure so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
