deniskuzZ commented on code in PR #6943:
URL: https://github.com/apache/hive/pull/6943#discussion_r4467401724
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/impl/ColStatsStoreImpl.java:
##########
@@ -1186,21 +1119,11 @@ private void executePlainSQL(String sql,
}
private GetHelper<TableName, String> createSubTransactionHelper(TableName
tableName) throws MetaException {
- return new GetHelper<TableName, String>(this, tableName) {
- @Override
- protected String describeResult() {
- return "A helper for managing sub-transaction";
- }
-
+ return new DirectSqlOnlyHelper<>(this, tableName) {
Review Comment:
This helper isn’t a direct-SQL-only operation. I think It's only used for
savepoint handling in the stats update paths, which work with JDO.
with allowJdo=false, the GetHelper constructor now always builds
MetaStoreDirectSql (runTestQuery() on every table/partition stats update, even
with try.direct.sql=false), and throws if the datastore isn’t direct-SQL
compatible, so stats updates would fail there. I think it should stay a plain
GetHelper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
