dengzhhu653 commented on code in PR #6935:
URL: https://github.com/apache/hive/pull/6935#discussion_r4520016331
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java:
##########
@@ -3826,7 +3826,8 @@ public void testAlterTableCascadeExceedsPartitionLimits()
throws Throwable {
List<FieldSchema> cols = tbl.getSd().getCols();
cols.add(new FieldSchema("new_col", ColumnType.STRING_TYPE_NAME, ""));
tbl.getSd().setCols(cols);
- //add new column with cascade option
+ // With PartitionsIterable, alter_table doesn't load all partitions into
+ // memory, it will change the partition's schema in bulk.
Review Comment:
It doesn't need, this property is to avoid loading lots of partitions into
memory that can cause oom, with PartitionsIterable, alter_table can update the
partitions incrementally, saves a table alter with large partitions, which
might be confusing before the PR(the alter_table doesn't touch the partition).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
