deniskuzZ commented on code in PR #6924:
URL: https://github.com/apache/hive/pull/6924#discussion_r4523303235
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -391,6 +394,22 @@ private static void configureOutputTableJobConf(TableDesc
tableDesc, JobConf job
}
}
+ /**
+ * The DV writers of a merge-on-read DML merge the previous deletes of the
data files they write. These are planned
+ * while the job is built.
+ */
+ @Override
+ public void configureJobConf(FileSinkDesc sinkDesc, JobConf jobConf) {
+ TableDesc tableDesc = sinkDesc.getTableInfo();
+ configureJobConf(tableDesc, jobConf);
+ Properties props = tableDesc.getProperties();
+ if (sinkDesc.getWriteOperation() == Operation.DELETE &&
!sinkDesc.isCopyOnWrite() &&
+ IcebergTableUtil.formatVersion(Maps.fromProperties(props)) >= 3) {
+ RewritableDeletes.addToJob(IcebergTableUtil.getTable(jobConf, props),
tableDesc.getTableName(),
Review Comment:
not valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
