dengzhhu653 commented on PR #6947: URL: https://github.com/apache/hive/pull/6947#issuecomment-6789217727
> > [@utafrali](https://github.com/utafrali) I don't add the regression test due to, I want to kept the diff small, 500 lines of a script file is noisy compared to few lines of fix, and this issue might depend on the environment. The jira provides a script file I can show the case locally, after patching the fix, issue is gone. > > you can avoid the 500 lines script if you make a test case that verifies this change in a different way: a unit test with a proper comment that fails if someone reverts this change would be extremely useful (we tend to break beeline silently from time to time) the patch looks good to me otherwise @abstractdog added the test, could you have a look please? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
