soumyakanti3578 commented on code in PR #6727:
URL: https://github.com/apache/hive/pull/6727#discussion_r4591206256
##########
ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java:
##########
@@ -902,4 +903,47 @@ private Set<String> getResultPathes(List<Path>
foundManifestFiles) {
}
return resultPathes;
}
+
+ @Test
+ public void testUnquoteJdbcIdentifierNullAndShortInputsUnchanged() {
+ assertNull(Utilities.unquoteJdbcIdentifier(null));
+ assertEquals("", Utilities.unquoteJdbcIdentifier(""));
+ // A single character cannot be a matched quote pair.
+ assertEquals("\"", Utilities.unquoteJdbcIdentifier("\""));
+ }
+
+ @Test
+ public void testUnquoteJdbcIdentifierUnquotedInputUnchanged() {
+ // Unquoted identifiers keep the current (case-insensitive) behaviour.
+ assertEquals("Country", Utilities.unquoteJdbcIdentifier("Country"));
+ assertEquals("country", Utilities.unquoteJdbcIdentifier("country"));
+ assertEquals("COUNTRY", Utilities.unquoteJdbcIdentifier("COUNTRY"));
+ }
+
+ @Test
+ public void testUnquoteJdbcIdentifierStripsSupportedQuotePairs() {
+ // ANSI / Oracle / Postgres double quotes.
+ assertEquals("Country", Utilities.unquoteJdbcIdentifier("\"Country\""));
+ // MySQL / MariaDB back-ticks.
+ assertEquals("Country", Utilities.unquoteJdbcIdentifier("`Country`"));
+ // SQL Server brackets.
+ assertEquals("Country", Utilities.unquoteJdbcIdentifier("[Country]"));
+ // Schema-style identifiers with mixed case are preserved after unquoting.
+ assertEquals("WorldData",
Utilities.unquoteJdbcIdentifier("\"WorldData\""));
Review Comment:
Checked this. Only the outer quote pair is removed, so "[Country]" becomes
[Country] and does not collide with Country. Added a note to the javadoc of
unquoteJdbcIdentifier and a test assertion for this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]