abstractdog commented on PR #6959:
URL: https://github.com/apache/hive/pull/6959#issuecomment-6976331252

   > > > > initial idea: can you please add a unit test that verifies this fix?
   > > > 
   > > > 
   > > > Thanks @abstractdog for checking it, in this change I am replacing the 
simple delimeter based splitting in case of source file scenario with 
`getCmdList` which is already getting used in beeline sessions for correctly 
splitting up the queries when multiple of them are provided simultaneously. so 
no separate ut is needed as `getCmdList` splitting is already covered by 
`TestCommands.testGetCmdList`
   > > 
   > > 
   > > hm, how do you mean no separate UT is needed, there is an exact failure 
here described as: `currently simple delimiter splitting results in parsing 
exeception in case string or comment contains semicolon` so if that's issue is 
present, theoretically, there should be a UT case which fails without this patch
   > 
   > what I meant was the change is using `getCmdList` method for splitting now 
and we already have a test case testing this method against the scenario 
mentioned:
   > 
   > 
https://github.com/apache/hive/blob/b828b70e67f47d23aa67a7c9cdb873e98ae1bc16/beeline/src/test/org/apache/hive/beeline/TestCommands.java#L218
   > 
   > 
   > so If I add a ut for this separately that would just like a wrapper to 
test the same functionality of splitting and we'll just be calling 
`sourceFileInternal` which will eventually use the `getCmdList` for splitting
   > I thought it would just be redundant but if you still think a ut is 
needed, I'll go ahead with it
   
   sorry, I mean, the existing unit test simply didn't cover this exact 
problem; otherwise, it should have failed already, which it hasn't, so still, a 
UT is needed that fails without this patch and passes with the patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to