aw-was-here commented on a change in pull request #67: YETUS-896 Add an emoji
column to the github vote table
URL: https://github.com/apache/yetus/pull/67#discussion_r306360442
##########
File path: precommit/src/main/shell/test-patch.d/github.sh
##########
@@ -610,9 +610,11 @@ function github_finalreport
comment=$(echo "${ourstring}" | cut -f5 -d\|)
if [[ "${vote}" = "H" ]]; then
- echo "||| _${comment}_ |" >> "${commentfile}"
+ echo "|||| _${comment}_ |" >> "${commentfile}"
+ elif [[ "${vote}" = "-1" ]]; then
+ echo "| :broken_heart: ${TP_VOTE_TABLE[${i}]}" >> "${commentfile}"
else
- echo "${TP_VOTE_TABLE[${i}]}" >> "${commentfile}"
+ echo "| :+1: ${TP_VOTE_TABLE[${i}]}" >> "${commentfile}"
Review comment:
There are three other values that need handling here, +0, -0, and 0.
Marking them with the same emoji as +1 is very misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
