aajisaka commented on a change in pull request #212:
URL: https://github.com/apache/yetus/pull/212#discussion_r564727194
##########
File path: shelldocs/src/main/python/shelldocs.py
##########
@@ -261,12 +261,12 @@ def lint(self):
getfuncs = {
"audience": self.getaudience,
"stability": self.getstability,
- "replaceable": self.replacetext,
+ "replaceable": self.getreplace,
}
validvalues = {
"audience": ("Public", "Private"),
"stability": ("Stable", "Evolving"),
- "replaceable": ("yes", "no"),
+ "replaceable": ("Yes", "No"),
Review comment:
https://github.com/apache/yetus/blob/227c762a0154c3465923d3b59ebdb3063bbd95ca/shelldocs/src/main/python/shelldocs.py#L174-L178
Here `self.getreplace` returns "Yes" or "No", therefore I changed the valid
values correspondingly to pass the `elif` statement below:
https://github.com/apache/yetus/blob/227c762a0154c3465923d3b59ebdb3063bbd95ca/shelldocs/src/main/python/shelldocs.py#L278-L283
Should I update `self.getreplace` to return "yes/no" instead of "Yes/No"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
