iwasakims commented on a change in pull request #227:
URL: https://github.com/apache/yetus/pull/227#discussion_r736539423
##########
File path: precommit/src/main/shell/plugins.d/cc.sh
##########
@@ -68,5 +68,5 @@ function cc_logfilter
declare output=$2
#shellcheck disable=SC1117
- "${GREP}" -i -E "^.*\.${CC_EXT_RE}\:[[:digit:]]*\:" "${input}" > "${output}"
+ "${GREP}" -i -E "^.*\.${CC_EXT_RE}\:[[:digit:]]*\:" "${input}" | sort >
"${output}"
Review comment:
I added maven_cc_logfilter similar to the maven_javac_logfilter. I think
I got expected outcome when I tried modified maven.sh for Hadoop.
```
$ ./dev-support/bin/test-patch --debug --project=hadoop
--personality=$PWD/dev-support/bin/hadoop.sh --plugins=all --dirty-workspace
--java-home=/usr/lib/jvm/java-1.8.0-openjdk --build-native=true /tmp/test.patch
$ head -n 10 /tmp/yetus-17580.12468/patch-compile-cc-root.txt
hadoop-common-project/hadoop-common/src/main/native/src/exception.c:121:
warning: `sys_errlist' is deprecated; use `strerror' or `strerror_r' instead
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:247:13:
warning: ‘locks_setup’ defined but not used [-Wunused-function]
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:247:13:
warning: ‘locks_setup’ defined but not used [-Wunused-function]
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:250:33:
warning: implicit declaration of function ‘dlsym_CRYPTO_num_locks’; did you
mean ‘dlsym_CRYPTO_malloc’? [-Wimplicit-function-declaration]
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:250:33:
warning: implicit declaration of function ‘dlsym_CRYPTO_num_locks’; did you
mean ‘dlsym_CRYPTO_malloc’? [-Wimplicit-function-declaration]
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:257:3:
warning: implicit declaration of function ‘dlsym_CRYPTO_set_id_callback’; did
you mean ‘CRYPTO_set_id_callback’? [-Wimplicit-function-declaration]
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:257:3:
warning: implicit declaration of function ‘dlsym_CRYPTO_set_id_callback’; did
you mean ‘CRYPTO_set_id_callback’? [-Wimplicit-function-declaration]
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:258:3:
warning: implicit declaration of function ‘dlsym_CRYPTO_set_locking_callback’;
did you mean ‘CRYPTO_set_locking_callback’? [-Wimplicit-function-declaration]
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:258:3:
warning: implicit declaration of function ‘dlsym_CRYPTO_set_locking_callback’;
did you mean ‘CRYPTO_set_locking_callback’? [-Wimplicit-function-declaration]
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/random/OpensslSecureRandom.c:261:13:
warning: ‘locks_cleanup’ defined but not used [-Wunused-function]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
