GauthamBanasandra commented on PR #289:
URL: https://github.com/apache/yetus/pull/289#issuecomment-1261170423

   @aw-was-here thanks for the suggestion, but Yetus still doesn't exclude the 
file.
   
   I tried the following -
   
   ## Excluding using `--excludes` option
   
   ```bash
   YETUS_ARGS+=("--excludes=dev-support/docker/Dockerfile_windows_10")
   ```
   
   Please note that I've used the path relative to its location in the Hadoop 
repo. Yetus is unable to exclude the file. Here's the Hadoop Jenkins run - 
https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-4936/7/pipeline/
   
   ## Excluding using `.yetus/excludes.txt`
   This doesn't exclude the file either. Here's the Hadoop Jenkins run - 
https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-4936/8/pipeline
   
   <hr>
   
   > Looking at that run, it looks like the real problem is that the Dockerfile 
isn't telling hadolint that it isn't an POSIX-type shell using the hadolint 
shell pragma.
   
   The `hadolint shell=powershell` pragma isn't supported on [hadolint 
v1.11.1](https://github.com/hadolint/hadolint/tree/v1.11.1) which is what the 
current Hadoop CI uses. I faced a lot of issues in upgrading hadolint and had 
to abandon that approach. Thus, I've resorted to excluding the file in the 
hadolint plugin itself.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@yetus.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to