ndimiduk commented on code in PR #291: URL: https://github.com/apache/yetus/pull/291#discussion_r990017908
########## asf-site-src/source/documentation/in-progress/precommit/advanced.html.md: ########## @@ -62,7 +62,9 @@ This function call registers the `pluginname` so that test-patch knows that it e function pluginname_filefilter ``` -defines the filefilter for the `pluginname` plug-in. +defines the filefilter for the `pluginname` plug-in. This function determines if the plug-in should Review Comment: nit: capitalize "defines" at the beginning of the sentence. ########## precommit/src/main/shell/plugins.d/hadolint.sh: ########## @@ -95,8 +91,8 @@ function hadolint_logic args=(--no-color) fi - for i in "${HADOLINT_CHECKFILES[@]}"; do - if [[ -f "${i}" ]]; then + for i in "${CHANGED_FILES[@]}"; do + if [[ "${i}" =~ Dockerfile ]] && [[ -f "${i}" ]]; then Review Comment: Why scope it to file names like `Dockerfile`? The previous values contained in `HADOLINT_CHECKFILES` used to be pre-filtered according to this expression? ########## precommit/src/main/shell/plugins.d/yamllint.sh: ########## @@ -54,19 +50,24 @@ function yamllint_logic pushd "${BASEDIR}" >/dev/null || return 1 - for i in "${YAMLLINT_CHECKFILES[@]}"; do - if [[ -f "${i}" ]]; then - fn="" - while read -r; do - if [[ -z "${fn}" ]]; then - fn=$REPLY - elif [[ -n "${REPLY}" ]]; then - # (space)line:col(space)error/warning(space)text - output=$(echo "${REPLY}" | awk '{$1=$1":"; $2=$2":"; print $0;}') - # fn:line:col:(space)error/warning:(space)text - echo "${fn}:${output}" >> "${PATCH_DIR}/${repostatus}-yamllint-result.txt" - fi - done < <("${YAMLLINT}" "${i}") + for i in "${CHANGED_FILES[@]}"; do + + if [[ ${i} =~ \.yaml$ ]] || Review Comment: Same question as for the `Dockerfile` filter previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@yetus.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org