aw-was-here commented on code in PR #309: URL: https://github.com/apache/yetus/pull/309#discussion_r1245476701
########## precommit/src/main/shell/test-patch-docker/Dockerfile: ########## @@ -145,14 +145,22 @@ RUN curl -sSL \ #### # Install hadolint (dockerfile lint) #### -FROM yetusbase AS yetushadolint +FROM yetusbase as yetushadolint_arm64 ARG HADOLINT_VERSION=2.12.0 SHELL ["/bin/bash", "-o", "pipefail", "-c"] -RUN if [[ "$(uname -m)" == "x86_64" ]]; then curl -sSL \ - https://github.com/hadolint/hadolint/releases/download/v$HADOLINT_VERSION/hadolint-Linux-"$(uname -m)" \ +RUN curl -sSl \ Review Comment: Probably worth experimenting with now. There were a few evolutions. `ADD` + `RUN` would generate 2 layers instead of a single `RUN` layer. Those extra layers added up in the final image making it much bigger than necessary. When we only built images for x86, there were checksums for all of the files. With multi-arch + multi-stage builds, those two problems are mostly non-existent now. Caching should be pretty good withe multi-stage builds so long as `yetusbase` doesn't change. If it does change, in some cases one really wants to rebuild that stage anyway. But that wouldn't have an impact on `ADD` anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@yetus.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
