alamb commented on code in PR #11340:
URL: https://github.com/apache/datafusion/pull/11340#discussion_r1669281761
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -761,11 +761,11 @@ impl OptimizerRule for PushDownFilter {
// Push down non-unnest filter predicate
// Unnest
- // Unenst Input (Projection)
+ // Unnest Input (Projection)
Review Comment:
drive by typo fixup
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -645,39 +643,6 @@ impl LogicalPlan {
Ok(LogicalPlan::Values(Values { schema, values }))
}
LogicalPlan::Filter(Filter { predicate, input }) => {
- // todo: should this logic be moved to Filter::try_new?
Review Comment:
this PR completes this TODO, per @jonahgao 's suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
