alamb commented on code in PR #11391:
URL: https://github.com/apache/datafusion/pull/11391#discussion_r1672625586
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -138,6 +138,10 @@ impl AggregateUDFImpl for Count {
return Ok(Box::new(CountAccumulator::new()));
}
+ if acc_args.input_exprs.len() > 1 {
Review Comment:
If any of the dialects allow the syntax I think the sqlparser-rs AST will
need to support multiple args.
This is kind of explained
https://github.com/sqlparser-rs/sqlparser-rs?tab=readme-ov-file#syntax-vs-semantics
(where what is a syntax error in some systems and a semantic one in others
needs to be enforced as a semantic error)
Thus I think the right thing to do here is check and error in DataFusion, as
@jonahgao 's PR does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
