milenkovicm commented on code in PR #1416:
URL:
https://github.com/apache/datafusion-ballista/pull/1416#discussion_r2749655377
##########
ballista/executor/src/executor_server.rs:
##########
@@ -661,6 +661,7 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> ExecutorGrpc
self.executor.function_registry.scalar_functions.clone(),
self.executor.function_registry.aggregate_functions.clone(),
self.executor.function_registry.window_functions.clone(),
+
self.executor.function_registry.table_functions.clone(),
Review Comment:
same as previous comment, do se need table functions here?
##########
ballista/core/src/registry.rs:
##########
@@ -34,29 +44,68 @@ pub struct BallistaFunctionRegistry {
pub aggregate_functions: HashMap<String, Arc<AggregateUDF>>,
/// Window user-defined functions.
pub window_functions: HashMap<String, Arc<WindowUDF>>,
+ /// Table functions.
Review Comment:
do we need table functions here? BFR is used at scheduler and executor after
logical plan has been ser/de so table function should be resolved to
TableProvider (or whatever is exactly) so table function should be encoded
between client and scheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
