alamb commented on PR #19994:
URL: https://github.com/apache/datafusion/pull/19994#issuecomment-3840934788
Divide by zero protection is looking pretty good:
```
divide_by_zero_protection/8192 rows, 0% zeros: DivideByZeroProtection
1.47 48.2±0.46µs
? ?/sec 1.00 32.8±0.23µs ? ?/sec
divide_by_zero_protection/8192 rows, 10% zeros: DivideByZeroProtection
2.08 95.6±1.22µs
? ?/sec 1.00 46.1±0.50µs ? ?/sec
divide_by_zero_protection/8192 rows, 50% zeros: DivideByZeroProtection
1.51 134.8±2.85µs
? ?/sec 1.00 89.3±0.57µs ? ?/sec
divide_by_zero_protection/8192 rows, 90% zeros: DivideByZeroProtection
1.00 58.5±0.43µs
? ?/sec 1.42 83.3±0.54µs ? ?/sec
```
For some reason the CI is now failing on this PR
When https://github.com/apache/datafusion/pull/20097 is merged, then we can
run the benchmarks again and see how much additional boost this special case
gives us
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
