manuzhang commented on code in PR #3370: URL: https://github.com/apache/datafusion-comet/pull/3370#discussion_r2759503023
########## docs/source/contributor-guide/sql-file-tests.md: ########## @@ -25,10 +25,21 @@ way to add expression and operator test coverage without writing Scala test code ## Running the tests +Run all SQL file tests: + +```shell +mvn test -Dsuites="org.apache.comet.CometSqlFileTestSuite" -Dtest=none +``` + +Run a single test file by adding the file name (without `.sql` extension) after the suite name: + ```shell -mvn test -pl spark -Dsuites="org.apache.comet.CometSqlFileTestSuite" -Dtest=none +mvn test -Dsuites="org.apache.comet.CometSqlFileTestSuite create_named_struct" -Dtest=none ``` +This uses ScalaTest's substring matching, so the argument must match part of the test name. +Test names follow the pattern `sql-file: expressions/<category>/<file>.sql [<config>]`. Review Comment: Is it possible to match a config? ########## docs/source/contributor-guide/sql-file-tests.md: ########## @@ -25,10 +25,21 @@ way to add expression and operator test coverage without writing Scala test code ## Running the tests +Run all SQL file tests: + +```shell +mvn test -Dsuites="org.apache.comet.CometSqlFileTestSuite" -Dtest=none +``` + +Run a single test file by adding the file name (without `.sql` extension) after the suite name: + ```shell -mvn test -pl spark -Dsuites="org.apache.comet.CometSqlFileTestSuite" -Dtest=none +mvn test -Dsuites="org.apache.comet.CometSqlFileTestSuite create_named_struct" -Dtest=none ``` +This uses ScalaTest's substring matching, so the argument must match part of the test name. +Test names follow the pattern `sql-file: expressions/<category>/<file>.sql [<config>]`. Review Comment: Is it possible to match a config as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
