killzoner commented on code in PR #1461:
URL:
https://github.com/apache/datafusion-ballista/pull/1461#discussion_r2821824193
##########
ballista/executor/src/config.rs:
##########
@@ -78,7 +78,7 @@ pub struct Config {
)]
pub concurrent_tasks: usize,
/// Task scheduling policy: pull-staged (executor polls) or push-staged
(scheduler pushes).
- #[arg(short = 's', long, default_value_t =
ballista_core::config::TaskSchedulingPolicy::PullStaged, help = "The task
scheduling policy for the scheduler, possible values: pull-staged, push-staged.
Default: pull-staged")]
+ #[arg(short = 's', long, default_value_t =
ballista_core::config::TaskSchedulingPolicy::PushStaged, help = "The task
scheduling policy for the scheduler, possible values: pull-staged, push-staged.
Default: pull-staged")]
Review Comment:
```suggestion
#[arg(short = 's', long, default_value_t =
ballista_core::config::TaskSchedulingPolicy::PushStaged, help = "The task
scheduling policy for the scheduler, possible values: pull-staged, push-staged.
Default: push-staged")]
```
But maybe we should default to clap help here instead of maintaining this
ourselves?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
