AlonSpivack commented on PR #20426: URL: https://github.com/apache/datafusion/pull/20426#issuecomment-3925402231
Thanks for putting this PR together @neilconway! Splitting out `type_union_coercion` is definitely the right architectural move. Regarding your dilemma about `text_col < 5`: I strongly agree with your intuition that we should **reject these queries entirely** with a clear type-mismatch/planning error, rather than trying to add special-case fallback logic. If a user actually wants to compare a string column to a number, they should be required to add an explicit `CAST`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
