nanookclaw commented on PR #22502: URL: https://github.com/apache/datafusion/pull/22502#issuecomment-4548182964
Rebased `fix/hash-expr-proto-hooks` onto current `main` and force-pushed head `20c2832988511969334e9ec4b189e1952365c3d3`. Conflict resolution kept upstream's `HashTableLookupExpr` proto hook behavior and kept this PR's `HashExpr` hook migration, so `HashExpr` now goes through `try_to_proto` / `try_from_proto` rather than the central `to_proto` downcast branch. Local validation passed: - `cargo fmt --check -- datafusion/proto/src/physical_plan/from_proto.rs datafusion/proto/src/physical_plan/to_proto.rs datafusion/physical-plan/src/joins/hash_join/partitioned_hash_eval.rs` - `cargo test -p datafusion-physical-plan hash_expr_try --features proto --lib` - `cargo check -p datafusion-proto` - `git diff --check upstream/main...HEAD` GitHub checks have restarted on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
