andygrove commented on PR #4417: URL: https://github.com/apache/datafusion-comet/pull/4417#issuecomment-4550295413
> Some post merge comments - > > * This really should have been two PRs. > * The codegen dispatcher is incredibly powerful but we must be careful to use it only when necessary. It's terrific that the implemented functions cause a host of issues, but perhaps we can restrict future conversions to those cases where compatible native implementations are impossible? This is just adding a cheaper fallback for expressions that are not yet implemented. I'm happy to review PRs to add native implementations and remove the fallbacks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
