yoavcloud commented on code in PR #2348:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2348#discussion_r3316654234
##########
src/parser/mod.rs:
##########
@@ -12184,6 +12184,15 @@ impl<'a> Parser<'a> {
after_newline = true;
self.next_token_no_skip();
}
+ // Tokenizer includes the newline in the single line
comment
+ // so we need to check for it specifically here, otherwise
the newline will
+ // not be consumed as a separate token.
+ Token::Whitespace(Whitespace::SingleLineComment { comment,
.. }) => {
Review Comment:
It would, I just thought it would be a disruptive change. However, I gave it
a try and I think it makes sense. Take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
