neilconway commented on code in PR #22474: URL: https://github.com/apache/datafusion/pull/22474#discussion_r3318312481
########## datafusion/core/tests/tpc-ds/1.sql: ########## @@ -1,26 +1,24 @@ --- Copyright 2015 Transaction Processing Performance Council - -with customer_total_return as -(select sr_customer_sk as ctr_customer_sk -,sr_store_sk as ctr_store_sk -,sum(SR_FEE) as ctr_total_return -from store_returns -,date_dim -where sr_returned_date_sk = d_date_sk -and d_year =2000 -group by sr_customer_sk -,sr_store_sk) - select c_customer_id -from customer_total_return ctr1 -,store -,customer -where ctr1.ctr_total_return > (select avg(ctr_total_return)*1.2 -from customer_total_return ctr2 -where ctr1.ctr_store_sk = ctr2.ctr_store_sk) -and s_store_sk = ctr1.ctr_store_sk -and s_state = 'SD' -and ctr1.ctr_customer_sk = c_customer_sk -order by c_customer_id -limit 100; - - +WITH Review Comment: If I'm reading this right, the differences are just * Formatting * Variable substitution -- the PR picks the qualification instantiation, we were previously using a different (legal) substitution. Using the qualification instantiation is probably better, unless we have some reason not to Right? ########## datafusion/core/tests/tpc-ds/1.sql: ########## @@ -1,26 +1,24 @@ --- Copyright 2015 Transaction Processing Performance Council - -with customer_total_return as -(select sr_customer_sk as ctr_customer_sk -,sr_store_sk as ctr_store_sk -,sum(SR_FEE) as ctr_total_return -from store_returns -,date_dim -where sr_returned_date_sk = d_date_sk -and d_year =2000 -group by sr_customer_sk -,sr_store_sk) - select c_customer_id -from customer_total_return ctr1 -,store -,customer -where ctr1.ctr_total_return > (select avg(ctr_total_return)*1.2 -from customer_total_return ctr2 -where ctr1.ctr_store_sk = ctr2.ctr_store_sk) -and s_store_sk = ctr1.ctr_store_sk -and s_state = 'SD' -and ctr1.ctr_customer_sk = c_customer_sk -order by c_customer_id -limit 100; - - +WITH Review Comment: If I'm reading this right, the differences are just * Formatting * Variable substitution -- the PR picks the qualification instantiation, we were previously using a different (legal) substitution. Right? Using the qualification instantiation is probably better, unless we have some reason not to -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
