adriangb commented on code in PR #22550:
URL: https://github.com/apache/datafusion/pull/22550#discussion_r3318792739
##########
datafusion/physical-expr/src/expressions/try_cast.rs:
##########
@@ -154,7 +217,20 @@ mod tests {
},
datatypes::*,
};
+ #[cfg(feature = "proto")]
+ use datafusion_common::DataFusionError;
use datafusion_physical_expr_common::physical_expr::fmt_sql;
+ #[cfg(feature = "proto")]
+ use
datafusion_physical_expr_common::physical_expr::proto_decode::PhysicalExprDecodeCtx;
+ #[cfg(feature = "proto")]
+ use
datafusion_physical_expr_common::physical_expr::proto_encode::PhysicalExprEncodeCtx;
+ #[cfg(feature = "proto")]
+ use datafusion_proto_models::protobuf::{self, physical_expr_node};
+
+ #[cfg(feature = "proto")]
+ use crate::proto_test_util::{
+ StubDecoder, StubEncoder, UnreachableDecoder, column_node,
+ };
Review Comment:
It'd be easier to just make a new test module:
https://github.com/apache/datafusion/blob/cab69a1d4aa8dab980e468e2ec8089ec66988fce/datafusion/physical-expr/src/expressions/like.rs#L348-L349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
