adriangb commented on issue #22418: URL: https://github.com/apache/datafusion/issues/22418#issuecomment-4565701164
> hey — looking at the remaining siblings under this epic, scalarfunctionexpr ([#22430](https://github.com/apache/datafusion/issues/22430)) is the only one not already taken, but the current physicalexprencodectx / physicalexprdecodectx don't expose the extension codec or the udf registry, which the existing to_proto.rs/from_proto.rs arms both lean on (codec.try_encode_udf / ctx.codec().try_decode_udf / ctx.task_ctx().udf). the trait docstring in physical-expr-common notes this is intentional pending more specialized helpers. > > before i pick this one up, is the expectation that the same pr extends the encode/decode contexts with udf helpers, or that a separate pr lands those helpers first and then this one is the consumer? happy to do either, want to make sure i'm sequencing it the way you'd want it reviewed. (context: i landed [#20767](https://github.com/apache/datafusion/pull/20767) a while back so i have the cla on file.) I think it would make sense to do it all in 1 PR so that it's more reviewable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
