ntjohnson1 commented on code in PR #1555:
URL:
https://github.com/apache/datafusion-python/pull/1555#discussion_r3319085713
##########
crates/core/src/udtf.rs:
##########
@@ -40,21 +53,21 @@ pub struct PyTableFunction {
pub(crate) inner: PyTableFunctionInner,
}
-// TODO: Implement pure python based user defined table functions
#[derive(Debug, Clone)]
pub(crate) enum PyTableFunctionInner {
- PythonFunction(Arc<Py<PyAny>>),
+ PythonFunction(PythonTableFunctionCallable),
FFIFunction(Arc<dyn TableFunctionImpl>),
}
#[pymethods]
impl PyTableFunction {
#[new]
- #[pyo3(signature=(name, func, session))]
+ #[pyo3(signature=(name, func, session, accepts_session=false))]
Review Comment:
Since this is an internal class I wonder if we need this extra argument. It
feels like potentially the presence of the session could already encode this,
but maybe that's more confusing than just adding the extra argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
